Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SLF4J warnings for skunk tests #605

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Fix SLF4J warnings for skunk tests #605

merged 1 commit into from
Apr 29, 2024

Conversation

milessabin
Copy link
Member

The missing logback test dependency resulted in the skunk tests spitting configuration warnings,

SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

Most likely this dependency was removed when the JS/JVM cross build for the skunk module landed. Adding the dependency back in for just the JVM build removes the noise.

@milessabin milessabin added bug Something isn't working testing skunk backend labels Apr 29, 2024
@milessabin milessabin self-assigned this Apr 29, 2024
@milessabin milessabin merged commit 6530762 into main Apr 29, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@milessabin milessabin

Labels
bug Something isn't working skunk backend testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@milessabin