Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude demo, benchmarks and profile from coverage #508

Merged
merged 2 commits into from
Nov 11, 2023

Conversation

ahoy196
Copy link
Contributor

@ahoy196 ahoy196 commented Nov 11, 2023

In the course of #507 @milessabin proposed that we exclude demo, benchmarks and profile from coverage for straightforward reasons.

@armanbilge proposed a mechanism of doing so, which is the path followed in the current PR which addresses the same. This uses the coverageEnabled flag in sbt project settings.

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c78389) 67.10% compared to head (590e9fa) 72.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
+ Coverage   67.10%   72.37%   +5.26%     
==========================================
  Files          40       32       -8     
  Lines        4682     4340     -342     
  Branches      951      927      -24     
==========================================
- Hits         3142     3141       -1     
+ Misses       1540     1199     -341     

see 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahoy196 ahoy196 mentioned this pull request Nov 11, 2023
@ahoy196
Copy link
Contributor Author

ahoy196 commented Nov 11, 2023

I went ahead and excluded docs and unidocs as well from the coverage.

Copy link
Member

@milessabin milessabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@milessabin milessabin merged commit ea03274 into typelevel:main Nov 11, 2023
10 checks passed
@ahoy196 ahoy196 mentioned this pull request Nov 11, 2023
@ahoy196 ahoy196 deleted the excludeFromCoverage branch November 11, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants