Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lambda-otel4s module #459
base: main
Are you sure you want to change the base?
Add lambda-otel4s module #459
Changes from 51 commits
1170ca8
09d4127
375b814
7ebde29
a5506a4
a17882b
c596060
88fa15a
11be471
08122de
5bee0a3
6b80150
5489668
4ae91a8
29f8248
db56620
a737654
5d0fb2b
9abdd5e
a961320
96ce0a9
68ea923
b2fcbf2
8f06d74
4c1cbb3
2e0937b
18768c2
51aad4a
a208070
2d435fd
ad3dbae
fe22625
c8f2913
e8fbf9d
501e76a
5e05972
a47540b
81ce08d
84d303b
73ed59c
eefbc7d
b87ae6c
1010972
92dded7
7687287
d35d875
a6f8e6c
684cb50
353ba48
07d2bbe
20d7b5f
c52d901
c062551
8ebf71c
e538c3f
4231bca
29edc99
9bcbb13
ef7d883
bb2970f
a99a656
9b5d7d6
ea168f5
9cca0f0
c46d6d3
15d8feb
fb3e029
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of putting these in the package object, we can put them in the companion object for
KernelSource
. Then they will automatically be in implicit scope without an import.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexcardell Can you look into this as well? 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@armanbilge done :)