-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import improvements from MTL 2.2 and 2.3 #2
Open
marcin-serwin
wants to merge
19
commits into
typeclasses:master
Choose a base branch
from
marcin-serwin:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR brings the code up to date with the current version of MTL. Among others it introduces the
Accum
andSelect
monad classes, defines alternative minimal required implementations (e.g.state
inStateMonad
), and removes old reexports.This MR is quite big, but each commit should be self contained and easy to cherry-pick if something is undesirable. The code is basically copied from MTL and adapted to use type families instead of dependencies. This means that some of the MTL breaking changes are also introduced so I've bumped the package version to
0.4.0.0
.Additionally, I've enabled the Safe Haskell extension everywhere so that the code can be imported to projects that also use it. MTL was using DerivingVia which is not considered Safe now, so I've rewritten those derivations by hand to avoid introducing
Trustworthy
modules.