Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory Bloat and explicit file paths #2

Open
tylerbarna opened this issue Jul 29, 2022 · 2 comments
Open

Directory Bloat and explicit file paths #2

tylerbarna opened this issue Jul 29, 2022 · 2 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed

Comments

@tylerbarna
Copy link
Owner

Need to reduce bloat in main directory, particularly with respect to priors being kept in the root directory. Also need to make clear what scripts do what and what order they're called.

Current state of repo is geared explicitly towards using nmma_fitter on the msi system; at various points, the pipeline makes explicit assumptions about absolute file paths that are located in the msi directory. Work needs to be done to make these various file paths either relative paths or arguments provided when executing the scripts.

One of my ongoing projects is getting the pipeline working on local systems, which should hopefully motivate more platform-agnostic changes to the codebase

@tylerbarna tylerbarna added documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed labels Jul 29, 2022
@tylerbarna tylerbarna self-assigned this Jul 29, 2022
@tylerbarna tylerbarna removed their assignment Aug 15, 2022
@tylerbarna
Copy link
Owner Author

would probably be good to pull any path references to a settings.json file or something. Could also use that as an opportunity to decouple models from the explicit definitions we make in make_jobs.py. If we define a models.json with a similar structure to the models dictionary that is currently being used, that might make it easier to dynamically add models in the future.

@tylerbarna
Copy link
Owner Author

May be good to try out these changes in the packaging branch and validate with localScript.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant