Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging of repo #17

Open
tylerbarna opened this issue Sep 7, 2022 · 2 comments
Open

Packaging of repo #17

tylerbarna opened this issue Sep 7, 2022 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@tylerbarna
Copy link
Owner

There's a lot of functionality that could probably be abstracted into an importable python package, but this would have to occur after #2 is addressed or else it won't be particularly useful. This would also make it easier to merge nmma_fitter into nmma main eventually

@tylerbarna tylerbarna added enhancement New feature or request help wanted Extra attention is needed labels Sep 7, 2022
@tylerbarna
Copy link
Owner Author

Some of the early lines of stats.py (when compiling the list of candidate directories and whatnot) would be problematic for this, but could be addressed by adding arguments to various functions calling a new function that generates all these lists/arrays/dictionaries if there is no argument with the required info isn't passed. Fairly easy rewrite, but probably won't implement until turning the repo into a package is more seriously worked on

@tylerbarna
Copy link
Owner Author

Similarly, see Issue #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant