Admin hotfix #20
Admin hotfix #20
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Shargrove09 Make sure I didn't do anything consequential. 99% is ui changes so should be fine. |
|
@tydolla00 Thoughts on moving session name and/or thumbnail to be inline with session URL? |
So the only reason I made it like that is because when you start resizing to smaller screens, I wanted the right side to be on top of the left (Session URL always on top of everything). And the only way to do what ur asking is to include session url in the grid layout. I could hack something together tho if it's really needed, just add -margin. What do you think about this Using -margin. The problem with this tho is that the session url still spans two columns so it's just going to overlap the right side. I think once we have everything set in stone, we can brainstorm the flow. |
Isn't session URL already apart of the grid? Regardless, I agree that it can be revisited later after some usage |
| className="rounded-md p-2" | ||
| placeholder="Enter Stat" | ||
| <div key={field.id} className="my-4 flex gap-3"> | ||
| {/* <span className="self-end">{field.stat}</span> */} |
There was a problem hiding this comment.
@tydolla00 I do think that we need to show the stat name next to each input field or as a placeholder at the very least for when there are games with multiple stats
There was a problem hiding this comment.
I think placeholder is better idea
There was a problem hiding this comment.
Down, might be overthinking but should we be worried about getting confused on which stat is which for games like CoD or RL after we input and are trying to check.
There was a problem hiding this comment.
So this is something I wanted to discuss as well, do we want to add extra layers of validation to where they can't pick duplicate stats, matches per set must be a specific length, etc.
There was a problem hiding this comment.
I'm going to come up with more ideas to better structure the UI. Closing this pr now, we can finish this discussion elsewhere.
No description provided.