-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create MainBranch Ci #428
base: main
Are you sure you want to change the base?
Create MainBranch Ci #428
Conversation
@leo42 I would prefer if we modify the existing docker workflow instead of adding a new one. I think that to accomplish what you want we just need to adjust the trigger so that it runs on every push to main. |
@scarmuega I merged it into a single file with filters for the tags to be issued only when you cut a release |
type=raw,value=stable,enable=${{ startsWith(github.ref, 'refs/tags/v') }} | ||
type=semver,pattern=v{{major}},enable=${{ startsWith(github.ref, 'refs/tags/v') }} | ||
type=semver,pattern=v{{major}}.{{minor}},enable=${{ startsWith(github.ref, 'refs/tags/v') }} | ||
type=semver,pattern=v{{version}},enable=${{ startsWith(github.ref, 'refs/tags/v') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure we need for an explicit enable
for semver tags?
I was under the impression that if the git tag is not present, the action will just skip semver.
Create dockerCi.yml
This Ci runs on every commit to main and creates a docker image with the tag "main"