Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create MainBranch Ci #428

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Create MainBranch Ci #428

wants to merge 5 commits into from

Conversation

leo42
Copy link

@leo42 leo42 commented Jan 13, 2025

Create dockerCi.yml

This Ci runs on every commit to main and creates a docker image with the tag "main"

@leo42 leo42 requested a review from scarmuega as a code owner January 13, 2025 10:42
@scarmuega
Copy link
Member

@leo42 I would prefer if we modify the existing docker workflow instead of adding a new one. I think that to accomplish what you want we just need to adjust the trigger so that it runs on every push to main.

@leo42
Copy link
Author

leo42 commented Jan 15, 2025

@scarmuega I merged it into a single file with filters for the tags to be issued only when you cut a release

Comment on lines +79 to +82
type=raw,value=stable,enable=${{ startsWith(github.ref, 'refs/tags/v') }}
type=semver,pattern=v{{major}},enable=${{ startsWith(github.ref, 'refs/tags/v') }}
type=semver,pattern=v{{major}}.{{minor}},enable=${{ startsWith(github.ref, 'refs/tags/v') }}
type=semver,pattern=v{{version}},enable=${{ startsWith(github.ref, 'refs/tags/v') }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure we need for an explicit enable for semver tags?
I was under the impression that if the git tag is not present, the action will just skip semver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants