fix: Use skip if not empty param #326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarmuega
reviewed
Oct 7, 2024
src/bin/dolos/bootstrap.rs
Outdated
Comment on lines
209
to
213
| if args.skip_if_not_empty & crate::common::open_wal(config).is_ok() { | ||
| info!("Skipping bootstrap, data already present."); | ||
| return Ok(()); | ||
| } | ||
|
|
There was a problem hiding this comment.
I think this premature open_wal could lock the second one that does the actual import if the struct is not dropped.
There was a problem hiding this comment.
oh, didn't know that. I'll check, and maybe put this in a closure to make sure it is dropped
|
This is already the behaviour now, so closing the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.