Cleanup of URL-SelectDirectories.swift

[vdhamer]

• Cleanup of URL-SelectDirectories (Fix: PublishingContext.copyResources() fails when Ignite included as a package #135)
• SwiftLint 0.57.0 gives errors. See
  • optional_string_data_conversion
  • https://www.hackingwithswift.com/example-code/language/how-to-convert-data-to-a-string

[twostraws]

Is this good to merge?

[vdhamer]

“Is this good to merge?” [ I need to fix this response by e-mail to use Markdown.] I have been using this branch for weeks now in my own project, and haven’t run into issues. But I would reject the following of my own changes... [Screenshot 2024-11-11 at 11.36.00 PM.png] … because it looks more like a note to myself. It seems more confusing than helpful. Sorry. A summary of the Pull Request changes: * Cosmetics: * Better comments on what selectDirectories(from:) is doing. In particular because of the 2 modes (executable package, include-able package). * Renamed struct holding Source directory and Build directory for clarity: SourceBuildDirectories > SourceAndBuildDirectories. * Fixed a typo in a comment (used to generate documentation). * Fixes * Fixed a compiler complaint about async requiring at least iOS 13. The entire package tends to have this problem if you run Ignite as an executable package (I don’t in my project). So there are more of these errors - somebody has grumbled about that before. You might want to fix the version compatibility at the Package level rather than my fix for a single function call). * Fixed a SwiftLint complaint about fallibility of String(decoding:as:). Apparently debatable SwiftLint rule. * Fixed a unit test where the function’s signature was probably changed, but the unit test was not updated. There is indeed still another failing unit test. I didn’t cause that. I believe PR #138 (by harlanhaskins, an Apple sw engineer) is about something else but includes a fix for your tests. <#138> [138.png] Ensure soft breaks in Markdown result in spaces in the resulting HTML by harlanhaskins · Pull Request #138 · twostraws/Ignite<#138> github.com<#138> About the iOS Target version (Xcode 16.2 beta 2): [Screenshot 2024-11-12 at 12.19.47 AM.png]

[twostraws]

I'm not seeing the screenshot, I'm afraid. Anyway, please get the code exactly where you want it, including merging in any changes from the current main branch, then I'll merge. Thank you!

[vdhamer]

Will do.

…

Sent from my iPhone On 12 Nov 2024, at 15:26, Paul Hudson ***@***.***> wrote:  I'm not seeing the screenshot, I'm afraid. Anyway, please get the code exactly where you want it, including merging in any changes from the current main branch, then I'll merge. Thank you! — Reply to this email directly, view it on GitHub<#136 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADGGUWG6YBFCJZLYZNAWZID2AIFY3AVCNFSM6AAAAABP2RZEYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZQGY3TSMJWHE>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[vdhamer]

Will replace this PR with a new PR (baseline has changed a lot).