Simplify operations in simplify.rs #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
spshah1701
commented
Sep 25, 2024
•
spshah1701
commented
- Simplified operations in simplify.rs
- Refactored code in op.rs.
twizmwazin
reviewed
Sep 25, 2024
| simplify!(lhs, rhs); | ||
| match (lhs.op(), rhs.op()) { | ||
| (AstOp::BVV(lhs), AstOp::BVV(rhs)) => { | ||
| ctx.srem(&ctx.bvv(lhs.clone())?, &ctx.bvv(rhs.clone())?)? |
There was a problem hiding this comment.
This is the same as the default case right? Instead if both of these are BVV, we want to calculate the actual signed remainder value using the type from clarirs_num and return a BVV instead of another SRem. This goes for all of the cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.