Skip to content

Commit

Permalink
Revert "3rdparty: jackson upgrade to 2.13.0"
Browse files Browse the repository at this point in the history
Problem

2.13.0 introduced a regression, where they were double-serializing.  We're
worried that this will lead to a substantial performance regression. Github
ticket: FasterXML/jackson-databind#3308

Solution

This reverts commit e27353b784543196b9f5fd572110e4b4fe04f4c4.

JIRA Issues: CSL-11459

Differential Revision: https://phabricator.twitter.biz/D780287
  • Loading branch information
mosesn authored and jenkins committed Nov 9, 2021
1 parent 1322d86 commit 9c6e01f
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 9 deletions.
7 changes: 0 additions & 7 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,11 @@ Note that ``PHAB_ID=#`` and ``RB_ID=#`` correspond to associated messages in com
Unreleased
----------

Breaking API Changes
~~~~~~~~~~~~~~~~~~~~

* util-jackson: The error message when failing to deserialize a character now correctly prints the non-character string. ``PHAB_ID=D744627``

Runtime Behavior Changes
~~~~~~~~~~~~~~~~~~~~~~~~

* util-cache: Update Caffeine cache library to version 2.9.2 ``PHAB_ID=D771893``

* util: Bump version of Jackson to 2.13.0. ``PHAB_ID=D744627``

21.10.0
-------

Expand Down
2 changes: 1 addition & 1 deletion build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Global / excludeLintKeys += scalacOptions // might be actually unused in util-do
val releaseVersion = "21.11.0-SNAPSHOT"

val slf4jVersion = "1.7.30"
val jacksonVersion = "2.13.0"
val jacksonVersion = "2.11.4"
val mockitoVersion = "3.3.3"
val mockitoScalaVersion = "1.14.8"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -823,7 +823,7 @@ class ScalaObjectMapperTest
|}
""".stripMargin,
withErrors = Seq(
"c: '-1' is not a valid Character"
"c: '' is not a valid Character"
)
)
}
Expand Down

0 comments on commit 9c6e01f

Please sign in to comment.