Skip to content

Commit

Permalink
Cut version 23.11
Browse files Browse the repository at this point in the history
Problem/Solution:

Cut version 23.11 of:
 - util
 - scrooge
 - finagle
 - twitter-server
 - finatra

Differential Revision: https://phabricator.twitter.biz/D1107956
  • Loading branch information
mattdickinson5 authored and jenkins committed Nov 2, 2023
1 parent 86d6784 commit a2d37fa
Show file tree
Hide file tree
Showing 10 changed files with 25 additions and 20 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ Note that ``PHAB_ID=#`` and ``RB_ID=#`` correspond to associated messages in com
Unreleased
----------

23.11.0
-------

No Changes

22.12.0
-------

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Scrooge

[![Build Status](https://github.com/twitter/scrooge/workflows/continuous%20integration/badge.svg?branch=develop)](https://github.com/twitter/scrooge/actions?query=workflow%3A%22continuous+integration%22+branch%3Adevelop)
[![Build Status](https://github.com/twitter/scrooge/workflows/continuous%20integration/badge.svg?branch=release)](https://github.com/twitter/scrooge/actions?query=workflow%3A%22continuous+integration%22+branch%3Arelease)
[![Project status](https://img.shields.io/badge/status-active-brightgreen.svg)](#status)
[![Gitter](https://badges.gitter.im/twitter/finagle.svg)](https://gitter.im/twitter/finagle?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge)
[![Maven Central](https://maven-badges.herokuapp.com/maven-central/com.twitter/scrooge-core_2.12/badge.svg)](https://maven-badges.herokuapp.com/maven-central/com.twitter/scrooge-core_2.12)
Expand Down
2 changes: 1 addition & 1 deletion build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Global / excludeLintKeys += scalacOptions
// 'git checkout develop; sbt publishLocal' to publish SNAPSHOT versions of these projects.

// All Twitter library releases are date versioned as YY.MM.patch
val releaseVersion = "23.11.0-SNAPSHOT"
val releaseVersion = "23.11.0"

lazy val versions = new {
val slf4j = "1.7.30"
Expand Down
12 changes: 6 additions & 6 deletions demos/scrooge-maven-demo/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -24,28 +24,28 @@
<dependency>
<groupId>com.twitter</groupId>
<artifactId>scrooge-core_2.12</artifactId>
<version>23.11.0-SNAPSHOT</version>
<version>23.11.0</version>
</dependency>
<dependency>
<groupId>com.twitter</groupId>
<artifactId>finagle-thrift_2.12</artifactId>
<version>23.11.0-SNAPSHOT</version>
<version>23.11.0</version>
</dependency>
<!--#dependencies-->
<dependency>
<groupId>com.twitter</groupId>
<artifactId>util-core_2.12</artifactId>
<version>23.11.0-SNAPSHOT</version>
<version>23.11.0</version>
</dependency>
<dependency>
<groupId>com.twitter</groupId>
<artifactId>util-codec_2.12</artifactId>
<version>23.11.0-SNAPSHOT</version>
<version>23.11.0</version>
</dependency>
<dependency>
<groupId>com.twitter</groupId>
<artifactId>finagle-core_2.12</artifactId>
<version>23.11.0-SNAPSHOT</version>
<version>23.11.0</version>
</dependency>
<dependency>
<groupId>junit</groupId>
Expand Down Expand Up @@ -129,7 +129,7 @@
<plugin>
<groupId>com.twitter</groupId>
<artifactId>scrooge-maven-plugin</artifactId>
<version>23.11.0-SNAPSHOT</version>
<version>23.11.0</version>
<configuration>
<thriftNamespaceMappings>
<thriftNamespaceMapping>
Expand Down
10 changes: 5 additions & 5 deletions doc/src/sphinx/SBTPlugin.rst
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ To use the scrooge-sbt-plugin, add the following lines to your

::

addSbtPlugin("com.twitter" % "scrooge-sbt-plugin" % "22.12.0")
addSbtPlugin("com.twitter" % "scrooge-sbt-plugin" % "23.11.0")

Incorporating this line makes the Scrooge plugin available for use by SBT.
Thrift files added to your project can now have code generated for them. By
Expand Down Expand Up @@ -41,8 +41,8 @@ An example using a `build.sbt` file.
name := "Scrooge Demo",
libraryDependencies ++= Seq(
"org.apache.thrift" % "libthrift" % "0.10.0",
"com.twitter" %% "scrooge-core" % "22.12.0",
"com.twitter" %% "finagle-thrift" % "22.12.0",
"com.twitter" %% "scrooge-core" % "23.11.0",
"com.twitter" %% "finagle-thrift" % "23.11.0",
scalaTest % Test
)
)
Expand Down Expand Up @@ -101,7 +101,7 @@ have Scrooge generate Java code.
scroogeLanguages in Compile := Seq("java"),
libraryDependencies ++= Seq(
"org.apache.thrift" % "libthrift" % "0.10.0",
"com.twitter" %% "scrooge-core" % "22.12.0",
"com.twitter" %% "finagle-thrift" % "22.12.0",
"com.twitter" %% "scrooge-core" % "23.11.0",
"com.twitter" %% "finagle-thrift" % "23.11.0",
scalaTest % Test
)
4 changes: 2 additions & 2 deletions doc/src/sphinx/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,14 @@ Maven users need to add the following to the pom.xml file:
<dependency>
<groupId>com.twitter</groupId>
<artifactId>scrooge-core_2.12</artifactId>
<version>22.12.0</version>
<version>23.11.0</version>
</dependency>

SBT users need this:

::

val scroogeCore = "com.twitter" %% "scrooge-core" % "22.12.0"
val scroogeCore = "com.twitter" %% "scrooge-core" % "23.11.0"

Building Scrooge
----------------
Expand Down
4 changes: 2 additions & 2 deletions scrooge-maven-plugin/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<artifactId>scrooge-maven-plugin</artifactId>
<packaging>maven-plugin</packaging>
<name>scrooge-maven-plugin</name>
<version>23.11.0-SNAPSHOT</version>
<version>23.11.0</version>
<prerequisites>
<maven>3.0.4</maven>
</prerequisites>
Expand Down Expand Up @@ -316,7 +316,7 @@
<dependency>
<groupId>com.twitter</groupId>
<artifactId>scrooge-generator_2.10</artifactId>
<version>23.11.0-SNAPSHOT</version>
<version>23.11.0</version>
</dependency>
<!-- Test Dependencies-->
<dependency>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<plugin>
<groupId>com.twitter</groupId>
<artifactId>scrooge-maven-plugin</artifactId>
<version>23.11.0-SNAPSHOT</version>
<version>23.11.0</version>
<configuration>
<classifier>idl</classifier>
<project implementation="com.twitter.stubs.ProjectIdlDependenciesStub">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<plugin>
<groupId>com.twitter</groupId>
<artifactId>scrooge-maven-plugin</artifactId>
<version>23.11.0-SNAPSHOT</version>
<version>23.11.0</version>
<configuration>
<localRepository>${localRepository}</localRepository>
<thriftOpts>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<plugin>
<groupId>com.twitter</groupId>
<artifactId>scrooge-maven-plugin</artifactId>
<version>23.11.0-SNAPSHOT</version>
<version>23.11.0</version>
<configuration>
<classifier>idl</classifier>
<project implementation="com.twitter.stubs.ProjectIdlDependenciesStub">
Expand Down

0 comments on commit a2d37fa

Please sign in to comment.