-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search bar improvments and Help page #823
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This could be a good opportunity to fix the search bar with the readthedocs in the summary pages. Which is simply not working at the moment :/ |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #823 +/- ##
==========================================
+ Coverage 92.29% 92.30% +0.01%
==========================================
Files 47 47
Lines 8514 8540 +26
Branches 1695 1696 +1
==========================================
+ Hits 7858 7883 +25
- Misses 385 386 +1
Partials 271 271 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
…r could be impredictible and this is somewhat hacky. Eventually I think the search bar should only display the ~20 first items and propose to load more if the expected entry is not found.
According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅ |
Implement one idea described in #822, more specifically:
Fixes #819
Other changes: