check if key in self._object_class_keys #220
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
reviewed
Mar 1, 2021
| @@ -247,7 +247,7 @@ def toWire(self): | |||
| lst = list(self.items()) | |||
| lst.sort() | |||
| for key, values in lst: | |||
| if key != "objectClass": | |||
| if key not in self._object_class_keys: | |||
There was a problem hiding this comment.
just above "objectClass" is handled explicitly too, does that need to use _object_class_keys ?
objectClasses = list(self.get("objectClass", []))
objectClasses.sort()
a.append(("objectClass", objectClasses))
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
=======================================
Coverage 83.28% 83.28%
=======================================
Files 87 87
Lines 11567 11567
Branches 1184 1184
=======================================
Hits 9634 9634
Misses 1815 1815
Partials 118 118
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for
keyto be either"objectClass"orb"objectClass". Other places use this self._object_class_keys to handle this scenario.