chore: add support for oauth in public apis #1049
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
manisha1997
reviewed
Dec 5, 2024
| import ApiTokenManager from "../http/bearer_token/ApiTokenManager"; | ||
| import TokenAuthStrategy from "../auth_strategy/TokenAuthStrategy"; | ||
|
|
||
| class ClientCredentialProvider extends CredentialProvider { |
There was a problem hiding this comment.
You need another Credential provider for Orgs API
There was a problem hiding this comment.
Added Orgs credential provider here
|
AsabuHere
approved these changes
Dec 9, 2024
|
To be completed by #1050 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
This PR adds support for accessing Twilio APIs using OAuth2 as well. It adds the following classes:
Token Managers to fetch access token
AuthStrategy to use tokens and create authString
Credential Providers to choose different auth strategy, be it - Basic Auth, OAuth or NoAuth (Limited use)
Modifications to Client to accomodate new changes without breaking previous flow
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.