Always prefer the sms body from the request over the cookie #365
Conversation
closes twilio#341 and perhaps twilio#266
|
It tested this for a length of time this is great! Looking to test this today, the code edits look great, hope this solves it. |
|
Finally had the ability to test this on the problem OpenVBX account. I believe this update fixes the "deleted" message appearing within the SMS inbox. Nice job! |
|
Hi, i've been having this same bug. how do i install the fix? just copy and replace the file on my OpenVBX installment? Sorry..a novice here. |
|
You could; it's fairly simple; have a look at the "files changed" tab, find the file in your deployment, and replace the red lines in that file with the green ones. The second red line is just a straight-up deletion. Be sure to test, and don't expect maintaining the change to be easy in the future unless you're really using git for version control. |
After six months or so of testing this on my own instance, I think I'm ready to have this fixed upstream. I haven't had any issues with preferring the request body over the cookie body.
Thoughts?
closes
#341
and perhaps
#266