-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Inline Code]: Update children prop #4109
Conversation
Run & review this pull request in StackBlitz Codeflow. |
🦋 Changeset detectedLatest commit: 155fd38 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
038ef92
to
e0f8efc
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 155fd38. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 155fd38:
|
Paste Run #8879
Run Properties:
|
Project |
Paste
|
Run status |
Passed #8879
|
Run duration | 02m 06s |
Commit |
155fd38379: Merge branch 'main' into truncate-inline
|
Committer | kodiakhq[bot] |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
67
|
.changeset/spicy-badgers-double.md
Outdated
"@twilio-paste/inline-code": minor | ||
"@twilio-paste/core": minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: this can be a patch since we're not adding any new props or exports
@@ -94,6 +95,16 @@ export const DisplayingAPIKey: StoryFn = () => { | |||
); | |||
}; | |||
|
|||
export const WithTruncate: StoryFn = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: could you also add a story with a truncated inline code within a block of regular paragraph text?
e0f8efc
to
0a76d9c
Compare
Paste Run #8878
Run Properties:
|
Project |
Paste
|
Run status |
Passed #8878
|
Run duration | 06m 01s |
Commit |
589a38b93b ℹ️: Merge 155fd38379e250d7f4a93f110af56199a0a361cc into 0d10a085be3940fcf59288edc69a...
|
Committer | Shoaib Ahmed |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
125
|
No description provided.