Use implicit whitespace in Pest grammar #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this I can now parse my personal Beancount journal.
|
Thanks for tackling this! I took a go at it a few weeks ago but ran into issues and then got busy. I'll watch for this to come out of draft and review at that point. |
|
The grammar now parses the output from |
twilco
approved these changes
Apr 26, 2019
|
While it seems like Beancount proper ignores org-mode titles vs. producing a token like our implementation might, I don't think that's a big deal and certainly nothing worth blocking this PR from merging. This looks great to me - if there's nothing else you wanted to do with this, go ahead and merge 👍 |
Thank you for reviewing! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First try at using the implicit whitespace feature of Pest. Test suite passes but I'm not completely confident that all rules work correctly.
Fixes #14