Add a confirmation modal for relation object deletion #8818
+34
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds a confirmation modal for deleting related objects in the object detail view, implementing a safety measure to prevent accidental deletions.
- Added confirmation modal using
createPortalin/packages/twenty-front/src/modules/object-record/record-show/record-detail-section/components/RecordDetailRelationRecordsListItem.tsx - Contains typo in state setter name
setIsDeleteRelatinoModalOpenthat needs fixing - Known issue: deleted objects remain visible until hard refresh, indicating cache invalidation needs addressing
- Modal implementation needs to handle edge cases for rapid state changes
- Warning text clarifies permanent deletion consequences and relationship impacts
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
100
to
101
| const [isDeleteRelationModalOpen, setIsDeleteRelatinoModalOpen] = | ||
| useState(false); |
There was a problem hiding this comment.
syntax: 'setIsDeleteRelatinoModalOpen' contains a typo ('Relatino')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8698
Summary
We decided to add a confirmation modal for the relation object deletion. It's gonna a bit of safety to the user interactions because this action can be disruptive even though it can be restored.
Solution
Used
createPortalfunction to address the issue where the vertical scrollbar shows over the modal. Added a logic that displays a confirmation modal for deletion in this file.I can update the text(title, description, and CTA) as necessary based on the feedback.
However, I observed an issue that the deleted object still shows up under the list until hard-refresh. I figured that can be addressed as a separate issue.
CleanShot.2024-11-29.at.16.02.22.mp4