Don't error when no secret path is provided

twentyfourg · Mar 2, 2021 · 2cc40f0 · 2cc40f0
1 parent 035014d
commit 2cc40f0
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/bitbucket-pipelines.yml b/bitbucket-pipelines.yml
@@ -6,7 +6,7 @@ pipelines:
           caches:
             - node
           name: Deploying to npm.24g.dev
-          image: node:10-alpine
+          image: node:12-alpine
           script:
             - npm install 
             - npm run lint

diff --git a/index.js b/index.js
@@ -45,8 +45,10 @@ function getAwsRequestUrl(region) {
 module.exports = async function getSecret(secretPath, options = {}) {
   // To be backwards compatible, we still use the KEY_NAME env var.
   // When secret manager is fully deprecated, we should swap this to SECRET_PATH
-  let path = secretPath;
-  if (!path) path = process.env.SECRET_PATH || process.env.KEY_NAME;
+  const path = secretPath || process.env.SECRET_PATH || process.env.KEY_NAME;
+
+  // No secret was passed. No SECRET_PATH || KEY_NAME environment variable set.
+  if (!path) return {};
 
   // Default bypassCache to false
   const bypassCache = options.bypassCache || false;

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@24g/vault",
-  "version": "1.0.22",
+  "version": "1.1.0",
   "description": "Module for interacting with Vault",
   "main": "index.js",
   "scripts": {