Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: endless concat #621

Merged
merged 3 commits into from
Apr 2, 2023
Merged

fix: endless concat #621

merged 3 commits into from
Apr 2, 2023

Conversation

tvytlx
Copy link
Contributor

@tvytlx tvytlx commented Aug 12, 2021

This pr fix #620

@trusktr
Copy link
Member

trusktr commented Dec 24, 2021

@tvytlx Hello! I would love to get this in. It needs a unit test update 🙏.

@tvytlx
Copy link
Contributor Author

tvytlx commented Dec 27, 2021

@trusktr request review

@trusktr
Copy link
Member

trusktr commented Apr 2, 2023

@tvytlx thanks for adding the test! Sorry for the late approval.

Btw, are you interested in helping with the project? We're looking for more people to help maintain and expand Tween.js: #638

@trusktr trusktr merged commit 720495c into tweenjs:master Apr 2, 2023
@trusktr
Copy link
Member

trusktr commented Apr 2, 2023

Oops, this went into the master branch, but we are now using main instead of master. I will fix it. Thanks for the contribution!

@trusktr trusktr mentioned this pull request Apr 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tweening to arrays of values has bug
2 participants
@tvytlx @trusktr