-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor jupyenv #524
Refactor jupyenv #524
Conversation
✅ Deploy Preview for tweag-jupyterwith ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
13b9db2
to
c1e0601
Compare
c09a9cb
to
9d5eff0
Compare
@balsoft refactor-stage1 has been DONE. |
8b42635
to
0dbe25f
Compare
7a640d3
to
7220e1e
Compare
@teto Thanks, fixed |
solve tweag#483, and enable the debugger by default
@GTrunSec , just wondering what work needs to be wrapped up here to push these changes. Is it just the failing haskell test that is blocking? I would love to help! |
@aniinbkln the building of Haskell is ok, just no maintainer(with the PR permission) in this project. |
mac m1 user awaiting fix ;) |
inputs.opam-nix.inputs.flake-utils.follows = "flake-utils"; | ||
inputs.opam-nix.inputs.nixpkgs.follows = "nixpkgs"; | ||
inputs.pre-commit-hooks.url = "github:cachix/pre-commit-hooks.nix"; | ||
inputs.pre-commit-hooks.inputs.flake-utils.follows = "flake-utils"; | ||
inputs.pre-commit-hooks.inputs.nixpkgs.follows = "nixpkgs"; | ||
inputs.pre-commit-hooks.inputs.flake-compat.follows = ""; | ||
# https://github.com/nix-community/poetry2nix/pull/1329 | ||
inputs.poetry2nix.url = "github:nix-community/poetry2nix"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably needs lock file update:
error: attribute 'overlays' missing
at /nix/store/cygya77xpaz7zxkdmr9klsgxfc1hc60y-source/flake.nix:71:11:
70| pkgs = nixpkgs.legacyPackages.${system}.appendOverlays [
71| poetry2nix.overlays.default
| ^
72| ];
Did you mean overlay?
I took this PR and updated nix inputs and poetry deps which resulted in a lot of build issues and even missing jupyter-lab bin. Had to fix pyproject.toml and add a bunch of overrides to get it working with latest nixos-unstable. You can find my efforts here https://github.com/anpin/jupyenv/tree/dev |
fixes: #485 #484 #497 #525 #482 #477 #478 #479 #388 #371 #328 #284 #527