Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support Typescript 5 #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AlexanderArvidsson
Copy link

@AlexanderArvidsson AlexanderArvidsson commented Jul 19, 2024

Updates the plugin to work with Typescript 5. Most likely not backwards compatible with Typescript 4, I have not tried it.
The biggest change is the consolidation of tsserverlibrary and typescript libraries, and the removal of project wide resolveModuleNames (they are deprecated anyway). It now relies on the language server host to resolve the twind DTS file.

Typescript 5 is stricter, so some parts of the code had to be updated with proper typing.

Solves #21, tw-in-js/vscode-twind-intellisense#24, tw-in-js/vscode-twind-intellisense#22, tw-in-js/vscode-twind-intellisense#23

I read that you plan to rework this plugin to use your new intellisense package, but until that is done this should suffice.
You'll probably want to publish the current plugin as a v4 version, but that's entirely up to you!

@xlboy
Copy link

xlboy commented Aug 11, 2024

This is a separate VSCode Twind intellisense extension that I developed, which only supports v1. It is still a work in progress. If you're interested, feel free to check it out.

@AlexanderArvidsson
Copy link
Author

This is a separate VSCode Twind intellisense extension that I developed, which only supports v1. It is still a work in progress. If you're interested, feel free to check it out.

Thanks, but I'm actually not using VS Code. A Typescript plugin (in my eyes) is always superior to any editor-specific plugin due to the fact it's agnostic, so it can be used with any editor.
Personally, I would push this plugin due to that, rather than a VS Code plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants