Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.20 #67

Merged
merged 2 commits into from
Apr 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions lib/components/menu/menu.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { AnimatePresence, motion } from "framer-motion";
import { useMemo, useState } from "react";
import { Arrow, useLayer } from "react-laag";
import { useLayer } from "react-laag";
import { twMerge } from "tailwind-merge";
import { useComponentStyle } from "../../customization/styles/theme.context";
import { IMenu, IMenuItem, IMenuKey } from "./menu.types";
Expand All @@ -18,7 +18,7 @@ export const Menu = ({

const theme = useComponentStyle("Menu");

const { triggerProps, layerProps, arrowProps, renderLayer } = useLayer({
const { triggerProps, layerProps, renderLayer } = useLayer({
isOpen: open || isOpen,
placement,
auto: true,
Expand All @@ -41,9 +41,9 @@ export const Menu = ({
return twMerge(theme.itemIcon());
}, [theme]);

const arrowClasses = useMemo(() => {
return twMerge(theme.arrow());
}, [theme]);
// const arrowClasses = useMemo(() => {
// return twMerge(theme.arrow());
// }, [theme]);

const onMenuItemClick = (value: IMenuKey) => {
if (value) {
Expand Down Expand Up @@ -90,14 +90,14 @@ export const Menu = ({
{...layerProps}
>
{renderMenuItems()}
<Arrow
{...arrowProps}
{/* <Arrow
backgroundColor="var(--color-neutral-5)" // color-component-background
borderColor="transparent"
className={arrowClasses}
borderWidth={1}
size={8}
/>
{...arrowProps}
/> */}
</motion.ul>
</AnimatePresence>
)}
Expand Down
6 changes: 6 additions & 0 deletions lib/components/popover/popover.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ const meta = {
children: {
type: "string",
},
trigger: {
description: "Popover trigger",
options: ["hover", "click"],
control: { type: "radio" },
},
placement: {
description: "Popover placement",
options: [
Expand Down Expand Up @@ -54,6 +59,7 @@ export const Primary: Story = {
args: {
children: "Click me",
placement: "bottom-start",
trigger: "hover",
content:
"Well, you only need the light when it's burning low. Only miss the sun when it starts to snow",
},
Expand Down
33 changes: 23 additions & 10 deletions lib/components/popover/popover.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { AnimatePresence, motion } from "framer-motion";
import { useMemo, useState } from "react";
import { Arrow, useLayer } from "react-laag";
import { Arrow, useHover, useLayer } from "react-laag";
import { twMerge } from "tailwind-merge";
import { useComponentStyle } from "../../customization/styles/theme.context";
import { IPopover } from "./popover.types";
Expand All @@ -12,15 +12,21 @@ export const Popover = ({
open,
onOpenChange,
popoverClassName,
trigger = "hover",
}: IPopover) => {
const isHoverTrigger = trigger === "hover";
const [isOpen, setOpen] = useState(false);
const [isHover, hoverProps] = useHover({
delayLeave: 200,
});

const theme = useComponentStyle("Popover");

const { triggerProps, layerProps, arrowProps, renderLayer } = useLayer({
isOpen: open || isOpen,
const { triggerProps, layerProps, renderLayer, arrowProps } = useLayer({
isOpen: open || isOpen || isHover,
placement,
auto: true,

triggerOffset: 10,
onOutsideClick: () => {
onOpenChange && onOpenChange(false);
Expand All @@ -39,16 +45,20 @@ export const Popover = ({
return (
<>
<span
{...(!isHoverTrigger
? {
onClick: () => {
const _isOpen = !isOpen;
setOpen(_isOpen);
onOpenChange && onOpenChange(_isOpen);
},
}
: hoverProps)}
{...triggerProps}
onClick={() => {
const _isOpen = !isOpen;
setOpen(_isOpen);
onOpenChange && onOpenChange(_isOpen);
}}
>
{children}
</span>
{(open || isOpen) &&
{(isHover || open || isOpen) &&
renderLayer(
<AnimatePresence>
<motion.div
Expand All @@ -57,15 +67,18 @@ export const Popover = ({
exit={{ opacity: 0 }}
className={classes}
{...layerProps}
{...(isHoverTrigger ? hoverProps : null)}
>
{content}
<Arrow
onPointerEnterCapture={undefined}
onPointerLeaveCapture={undefined}
{...arrowProps}
backgroundColor="var(--color-neutral-5)" // color-component-background
borderColor="transparent"
className={arrowClasses}
borderWidth={1}
size={8}
size={8}
/>
</motion.div>
</AnimatePresence>
Expand Down
1 change: 1 addition & 0 deletions lib/components/popover/popover.types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,5 @@ export interface IPopover {
content?: React.ReactNode;
children?: React.ReactNode;
popoverClassName?: string;
trigger?: "hover" | "click";
}
13 changes: 9 additions & 4 deletions lib/components/tooltip/tooltip.tsx
Original file line number Diff line number Diff line change
@@ -1,21 +1,23 @@
import { AnimatePresence, motion } from "framer-motion";
import { useMemo } from "react";
import { Arrow, useHover, useLayer } from "react-laag";
import { twMerge } from "tailwind-merge";
import { useComponentStyle } from "../../customization/styles/theme.context";
import { AnimatePresence, motion } from "framer-motion";
import { ITooltip } from "./tooltip.types";
import { useMemo } from "react";

export const Tooltip = ({
children,
content,
placement,
tooltipClassName,
}: ITooltip) => {
const [isHover, hoverProps] = useHover();
const [isHover, hoverProps] = useHover({
delayLeave: 200,
});

const theme = useComponentStyle("Tooltip");

const { triggerProps, layerProps, arrowProps, renderLayer } = useLayer({
const { triggerProps, layerProps, renderLayer, arrowProps } = useLayer({
isOpen: isHover,
placement,
auto: true,
Expand Down Expand Up @@ -44,9 +46,12 @@ export const Tooltip = ({
exit={{ opacity: 0 }}
className={classes}
{...layerProps}
{...hoverProps}
>
{content}
<Arrow
onPointerEnterCapture={undefined}
onPointerLeaveCapture={undefined}
{...arrowProps}
backgroundColor="black"
className={arrowClasses}
Expand Down
Loading
Loading