Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proc date voting #691

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Proc date voting #691

merged 2 commits into from
Jan 3, 2025

Conversation

mgoldhirsh
Copy link
Contributor

Describe your changes

Running some HEDIS models we noticed we has some proc dates with a odd date, '1990-01-01', an mco's null code for admissions date. Looking at the field history we see that admissions date is the first choice in the procedure code voting. I believe a HCPCS/CPT procedure code should correspond more closely with a claim line date, claim start date and admission date less so. Adding claim line to be the first choice, and demoting admission date to third choice after claim start date since it is less likely to be populated and want to avoid similar issues for others

Slack thread

How has this been tested?

I ran this code on our systems, and it completed without error and returned the desired results (matching our claims calculated hedis measures to those reported by the mcos

Reviewer focus

I would ask if we really want to include dates beyond the claim line date and claim start dates. For our HEDIS work, we count on distinct proc dates. We also are pulling in procedure information from clinical sources. If a proc date is misstated this would cause an incorrect count, and for this reason I am a little inclined to not default to dates other than line date

Checklist before requesting a review

  • I have added at least one Github label to this PR (bug, enhancement, breaking change,...)
  • My code follows style guidelines
  • (New models) YAML files are categorized by sub folder and models listed in alphabetical order
  • (New models) I have added a config to each new model to enable it for claims and/or clinical data
  • (New models) I have added the variable tuva_last_run to the final output
  • (Optional) I have recorded a Loom to explain this PR

Package release checklist

  • I have updated dbt docs
  • I have updated the version number in the dbt_project.yml

(Optional) Gif of how this PR makes you feel

Loom link

Copy link

github-actions bot commented Jan 3, 2025

Workflow has finished with the following statuses:

  • BigQuery Clinical and Claims: success
  • BigQuery Claims: success
  • BigQuery Clinical: success
  • Fabric Clinical and Claims: success
  • Fabric Claims: success
  • Fabric Clinical: success
  • Redshift Clinical and Claims: success
  • Redshift Claims: success
  • Redshift Clinical: success
  • Snowflake Clinical and Claims: success
  • Snowflake Claims: success
  • Snowflake Clinical: success

@thutuva
Copy link
Member

thutuva commented Jan 3, 2025

Hi @mgoldhirsh - Thank you for submitting these changes! I've approved the code change and run it through our CI/CD process successfully. I will now merge to main. Cheers!

@thutuva thutuva merged commit d3ca1aa into tuva-health:main Jan 3, 2025
@mgoldhirsh
Copy link
Contributor Author

Thank you @thutuva, much appreciated <3

@sarah-tuva sarah-tuva added the bug Something isn't working label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants