-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tuva Data Model Change: Add person_id #685
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 77310fc.
sarah-tuva
added
the
breaking-change
Changes have been made that may cause other components to fail
label
Dec 10, 2024
thutuva
previously approved these changes
Dec 12, 2024
bradmontierth
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Please include a summary of any changes.
This PR includes several breaking changes and will be part of a new minor release,
0.13.0
. You must make changes to your input layer mapping before using this version. Please refer to the mapping guide on Docs for questions about mapping.patient_id
withperson_id
in the claims input layer.person_id
as an additional identifier in the clinical input layer.person_id
as an additional field to all relevant models in Core.patient_id
withperson_id
in all data marts after Core.phone
to clinical patient input layer.How has this been tested?
Please describe the tests you ran to verify your changes. Provide instructions or code to reproduce output.
Ran
dbt build --full-refresh
in integration_tests and ci_testing.Reviewer focus
Please summarize the specific items you’d like the reviewer(s) to look into.
Checklist before requesting a review
tuva_last_run
to the final outputPackage release checklist
dbt_project.yml
(Optional) Gif of how this PR makes you feel
Loom link
https://www.loom.com/share/85660bbc36fa40588aeb1ad9a316ed38?sid=45fdcb82-5593-4d64-af03-7d7213e7316a