Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuva Data Model Change: Add person_id #685

Merged
merged 41 commits into from
Dec 12, 2024
Merged

Tuva Data Model Change: Add person_id #685

merged 41 commits into from
Dec 12, 2024

Conversation

sarah-tuva
Copy link
Member

@sarah-tuva sarah-tuva commented Dec 10, 2024

Describe your changes

Please include a summary of any changes.

This PR includes several breaking changes and will be part of a new minor release, 0.13.0. You must make changes to your input layer mapping before using this version. Please refer to the mapping guide on Docs for questions about mapping.

  • Replaced patient_id with person_id in the claims input layer.
  • Added person_id as an additional identifier in the clinical input layer.
  • Added person_id as an additional field to all relevant models in Core.
  • Replaced patient_id with person_id in all data marts after Core.
  • Added data_source to primary surrogate keys in Core where it was missing.
  • Added new model person_id_crosswalk to Core.
  • Added phone to clinical patient input layer.
  • Updated doc blocks.
  • Update integration tests and ci testing.

How has this been tested?

Please describe the tests you ran to verify your changes. Provide instructions or code to reproduce output.

Ran dbt build --full-refresh in integration_tests and ci_testing.

Reviewer focus

Please summarize the specific items you’d like the reviewer(s) to look into.

Checklist before requesting a review

  • I have added at least one Github label to this PR (bug, enhancement, breaking change,...)
  • My code follows style guidelines
  • (New models) YAML files are categorized by sub folder and models listed in alphabetical order
  • (New models) I have added a config to each new model to enable it for claims and/or clinical data
  • (New models) I have added the variable tuva_last_run to the final output
  • (Optional) I have recorded a Loom to explain this PR

Package release checklist

  • I have updated dbt docs
  • I have updated the version number in the dbt_project.yml

(Optional) Gif of how this PR makes you feel

Loom link

https://www.loom.com/share/85660bbc36fa40588aeb1ad9a316ed38?sid=45fdcb82-5593-4d64-af03-7d7213e7316a

@sarah-tuva sarah-tuva added the breaking-change Changes have been made that may cause other components to fail label Dec 10, 2024
thutuva
thutuva previously approved these changes Dec 12, 2024
@sarah-tuva sarah-tuva merged commit 8e57620 into main Dec 12, 2024
7 of 8 checks passed
@sarah-tuva sarah-tuva deleted the add-person-id branch December 12, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Changes have been made that may cause other components to fail
Projects
Status: Ready to Release
Development

Successfully merging this pull request may close these issues.

3 participants