Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(calendar): add day view #275

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

feat(calendar): add day view #275

wants to merge 5 commits into from

Conversation

nicholaschiang
Copy link
Member

@nicholaschiang nicholaschiang commented Nov 1, 2021

Fixes TB-136 and TB-131

@linear
Copy link

linear bot commented Nov 1, 2021

TB-136 Add day view to calendar

While I'm adding the day view to our calendar, I should probably also work on fixing some of the other calendar bugs (e.g. TB-56 and TB-131).

@vercel
Copy link

vercel bot commented Nov 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tutorbook/tutorbook/3u4URDjPCAwABTt2dGxDGBQnDK3e
✅ Preview: https://tutorbook-git-calendar-tutorbook.vercel.app

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #275 (1fc9a0c) into develop (d873ac5) will increase coverage by 1.52%.
The diff coverage is 15.89%.

❗ Current head 1fc9a0c differs from pull request most recent head 2c7b2e9. Consider uploading reports for the commit 2c7b2e9 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #275      +/-   ##
===========================================
+ Coverage    67.46%   68.98%   +1.52%     
===========================================
  Files          223      224       +1     
  Lines         4767     4788      +21     
  Branches      1277     1288      +11     
===========================================
+ Hits          3216     3303      +87     
+ Misses        1551     1485      -66     
Impacted Files Coverage Δ
components/calendar/components.tsx 100.00% <ø> (ø)
components/calendar/daily-display.tsx 0.00% <0.00%> (ø)
components/calendar/dialog/surface.tsx 0.00% <0.00%> (ø)
components/calendar/meetings/item.tsx 0.00% <0.00%> (ø)
components/calendar/state.ts 25.00% <0.00%> (-2.28%) ⬇️
components/calendar/place-meetings.ts 22.22% <25.00%> (+2.22%) ⬆️
components/calendar/search-bar.tsx 57.14% <50.00%> (-1.20%) ⬇️
components/calendar/header.tsx 59.37% <52.94%> (+13.22%) ⬆️
components/calendar/index.tsx 47.55% <85.71%> (+1.83%) ⬆️
components/calendar/weekly-display.tsx 80.82% <100.00%> (+1.09%) ⬆️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f6d194...2c7b2e9. Read the comment docs.

@cypress
Copy link

cypress bot commented Nov 1, 2021



Test summary

21 11 0 2Flakiness 3


Run details

Project tutorbook
Status Failed
Commit 2c7b2e9
Started Jan 4, 2022 10:09 PM
Ended Jan 4, 2022 10:22 PM
Duration 12:51 💡
OS Linux Ubuntu - 20.04
Browser Chrome 96

View run in Cypress Dashboard ➡️


Failures

org/users/id/index.spec.ts Failed
1 User display page > collects profiles before booking meetings
2 User display page > lets parents book meetings for their kids
3 User display page > signs users up before booking meetings
org/search.spec.ts Failed
1 Search page > restricts access to school data
2 Search page > partitions search results by org
3 Search page > filters users by subjects, langs, and name
org/signup.spec.ts Failed
1 Signup page > validates email addresses
profile.spec.ts Failed
1 Profile page > updates volunteer profiles
org/users/index.spec.ts Failed
1 Users page > copies org links and filters users
org/settings/index.spec.ts Failed
1 Org settings page > displays and updates org settings
This comment includes only the first 10 test failures. See all 11 failures in the Cypress Dashboard.

Flakiness

profile.spec.ts Flakiness
1 Profile page > retries failed update requests
login.spec.ts Flakiness
1 Login page > navigates to specified redirect destination
calendar.spec.ts Flakiness
1 Calendar page > creates, edits, and cancels meetings

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@linear
Copy link

linear bot commented Nov 1, 2021

TB-131 Polish calendar dialog positioning

The calendar meeting dialog should be positioned better so that it's content is always fully on-screen (when the screen height is equal to or greater than the dialog content height, that is). I should try to recreate the Google Calendar dialog positioning algorithm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant