Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: address ESLint errors #262

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

wip: address ESLint errors #262

wants to merge 1 commit into from

Conversation

nicholaschiang
Copy link
Member

Fixes TB-139

@linear
Copy link

linear bot commented Oct 25, 2021

@vercel
Copy link

vercel bot commented Oct 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tutorbook/tutorbook/3xsKQTUpa3hR23zjk4yUHyhq91zG
✅ Preview: https://tutorbook-git-lint-tutorbook.vercel.app

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #262 (0ed0510) into develop (86cf428) will decrease coverage by 4.26%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #262      +/-   ##
===========================================
- Coverage    70.44%   66.17%   -4.27%     
===========================================
  Files          218      218              
  Lines         4568     4568              
  Branches      1244     1244              
===========================================
- Hits          3218     3023     -195     
- Misses        1350     1545     +195     
Impacted Files Coverage Δ
components/analytics/graph.tsx 0.00% <ø> (ø)
components/button/index.tsx 87.50% <ø> (ø)
components/calendar/meetings/item.tsx 0.00% <0.00%> (ø)
components/calendar/state.ts 33.33% <0.00%> (ø)
components/home/index.tsx 100.00% <ø> (ø)
components/login/index.tsx 97.72% <ø> (ø)
components/navigation/pop-over.tsx 67.64% <ø> (ø)
components/notification/index.tsx 100.00% <ø> (ø)
components/settings/context.ts 75.00% <0.00%> (ø)
components/settings/home.tsx 36.84% <ø> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86cf428...0ed0510. Read the comment docs.

@cypress
Copy link

cypress bot commented Oct 25, 2021



Test summary

28 5 0 0Flakiness 2


Run details

Project tutorbook
Status Failed
Commit 0ed0510
Started Oct 25, 2021 10:20 PM
Ended Oct 25, 2021 10:37 PM
Duration 17:36 💡
OS Linux Ubuntu - 20.04
Browser Chrome 94

View run in Cypress Dashboard ➡️


Failures

users/id/index.spec.ts Failed
1 User display page > collects profiles before booking meetings
2 User display page > lets parents book meetings for their kids
users/index.spec.ts Failed
1 Users page > falls back to invisible textarea copy-paste
2 Users page > copies org links and filters users
settings/index.spec.ts Failed
1 Org settings page > displays and updates org settings

Flakiness

cypress/tests/org/search.spec.ts Flakiness
1 Search page > partitions search results by org
2 Search page > filters users by subjects, langs, and name

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant