Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Prettier and Eslint with Biome #647

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Replace Prettier and Eslint with Biome #647

merged 3 commits into from
Sep 3, 2024

Conversation

Murderlon
Copy link
Member

  • Remove packages/eslint-config-custom and all its dependencies
  • Remove eslintrc and eslint deps
  • Remove prettierrc and prettier deps
  • Remove lint and format commands from all packages. This is now only ran from root.

@Murderlon Murderlon self-assigned this Aug 20, 2024
Copy link

changeset-bot bot commented Aug 20, 2024

⚠️ No Changeset found

Latest commit: 6a0a561

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

socket-security bot commented Aug 20, 2024

Copy link

socket-security bot commented Aug 20, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@biomejs/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@Murderlon
Copy link
Member Author

@SocketSecurity ignore npm/@biomejs/[email protected]

@Murderlon Murderlon marked this pull request as ready for review August 21, 2024 11:41
@Murderlon Murderlon merged commit 227ae81 into main Sep 3, 2024
3 of 4 checks passed
@Murderlon Murderlon deleted the biome branch September 3, 2024 09:48
Murderlon added a commit to idanto/tus-node-server that referenced this pull request Sep 5, 2024
* main:
  @tus/server: make test less flaky
  Correctly ignore dist/ in biome.json
  Replace Prettier and Eslint with Biome (tus#647)
  Revert "Bump rimraf from 3.0.2 to 6.0.1 (tus#649)"
  Bump sinon from 17.0.1 to 18.0.0 (tus#648)
  Bump rimraf from 3.0.2 to 6.0.1 (tus#649)
Murderlon added a commit that referenced this pull request Sep 5, 2024
* main:
  [ci] release (#644)
  @tus/server: add allowedCredentials and allowedOrigins options (#636)
  Bump micromatch from 4.0.5 to 4.0.8 (#653)
  @tus/server: make test less flaky
  Correctly ignore dist/ in biome.json
  Replace Prettier and Eslint with Biome (#647)
  Revert "Bump rimraf from 3.0.2 to 6.0.1 (#649)"
  Bump sinon from 17.0.1 to 18.0.0 (#648)
  Bump rimraf from 3.0.2 to 6.0.1 (#649)
  Change name of CI workflow
  Remove turbo (#646)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant