Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contact manager for Gazebo 2.0 #16

Merged
merged 1 commit into from
Nov 22, 2014

Conversation

trainman419
Copy link
Contributor

I've updated the gazebo create plugin for Gazebo2. It's late and I don't have time to test it, but it at least seems sound and it compiles.

This should resolve #7

It may also be worth consolidating the hydro, hydro-devel and indigo branches; it looks like they've diverged, and there are changes in the hydro branch that haven't made it to the indigo branch yet...

@trainman419
Copy link
Contributor Author

It looks like the contact manager is being used to simulate drop sensors. Testing that those work properly in simulation may be tricky.

@bit-pirate
Copy link
Member

Have you checked the kobuki plugin? We probably had to jump through the
same hoops.

On 19 November 2014 18:47, Austin [email protected] wrote:

It looks like the contact manager is being used to simulate drop sensors.
Testing that those work properly in simulation may be tricky.


Reply to this email directly or view it on GitHub
#16 (comment)
.

Innovation Team Leader
Yujin Robot
Seoul, Republic of Korea
Twitter: @yujinrobotinno
Website: http://inno.yujinrobot.com
Email: [email protected]
Phone: +82-70-46577073

@trainman419
Copy link
Contributor Author

There's an open issue, but no resolution, and I haven't been able to find a commit in the kobuki_desktop repository that makes similar changes.

I suspect the kobuki simulator is simulating the drop sensors differently.

@trainman419
Copy link
Contributor Author

Scratch that; the contact detection is actually simulating the bump sensors. The kobuki node does this differently, by polling the bumper for contacts instead of subscribing to the contacts from the simulator, and this is why this issue isn't present in the kobuki gazebo plugin.

I ran it through gazebo a bit, and it runs, but it doesn't appear to detect bumps properly. Otherwise, it seems to work ok.

@trainman419
Copy link
Contributor Author

At least part of the problem with the bump detection is that there are no contacts between the base and the world, because the collision geometry is too small. See: trainman419/turtlebot_create@21ccdc4

With that fixed, and contacts properly generated, it still looks like contacts aren't properly filtered or subscribed to. At this point it probably needs someone who knows gazebo better than I do.

I'm starting to wonder if this ever worked, and if we should just release it with my partial fix, and fix the remaining issues later.

jihoonl added a commit that referenced this pull request Nov 22, 2014
Update contact manager for Gazebo 2.0
@jihoonl jihoonl merged commit ca7201c into turtlebot:indigo Nov 22, 2014
@jihoonl
Copy link
Member

jihoonl commented Nov 22, 2014

Yeah agree

@jihoonl
Copy link
Member

jihoonl commented Nov 22, 2014

thanks for the fix.

jihoonl added a commit to yujinrobot/yujin_tools that referenced this pull request Dec 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants