-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bindings/java] Implement for jdbc's ResultSet
#743
Open
seonWKim
wants to merge
18
commits into
tursodatabase:main
Choose a base branch
from
seonWKim:java-bindings-limbo-resultset
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[bindings/java] Implement for jdbc's ResultSet
#743
seonWKim
wants to merge
18
commits into
tursodatabase:main
from
seonWKim:java-bindings-limbo-resultset
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seonWKim
force-pushed
the
java-bindings-limbo-resultset
branch
from
January 19, 2025 08:15
a797418
to
92058d2
Compare
Not sure why the test fails on workflow but works on my local machine. I'll further investigate and add the work in the following PRs(as this PR is getting big) Maybe it's due to more restricted environment e.g. less number of threads(maybe one thread) |
…CXXX and favor composition instead
…ll which is the error case
seonWKim
force-pushed
the
java-bindings-limbo-resultset
branch
from
January 19, 2025 12:56
1ef296d
to
e8a62b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Associate jdbc's
ResultSet
with the returned values from limbo's step function.Changes
Rust
Java_org_github_tursodatabase_core_LimboStatement_step
now returns an object of java'sLimboStepResult.java
Java
LimboStepResult.java
in order to distinguish the type ofStepResult
(which limbo returns) and to encapsulate the interpretation of limbo'sStepResult
JDBC4ResultSet
inheritingLimboResultSet
to composition. IMO when using inheritance, it's too burdensome to fit unmatching parts together.JDBC4Statement.java
'sexecute
methodResultSet
created after executing the qury, it's now able to determine the (boolean) result.Reference