-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Java bindings #613
Conversation
8061001
to
8f75d8b
Compare
the force push made some mess 🙏 |
} | ||
} | ||
|
||
private void printElementType(Object element) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for debugging purposes, we can remove later stage on development
import org.github.tursodatabase.limbo.Limbo; | ||
|
||
public class Main { | ||
public static void main(String[] args) throws Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for debugging purpose, let's remove it at later stage of development
Hey @seonWKim, awesome, thanks for doing this! I will review this and happy to merge as a nice incremental step! However, I think the path for Java ecosystem is to turn this into a JDBC driver, similar to https://github.com/xerial/sqlite-jdbc. |
@penberg Thanks for the review. I should look into that project. 🙏 I think this PR can be a wrapper for native functions supported by limbo as sqlite-jdbc did. After deciding on which native functions to support(maybe similar to sqlite-jdbc), we can separate the java bindings to another repository(a long future work maybe). Currently I've added features by referring to python bindings. |
Hey @seonWKim, no, I think it's good that the bindings are in the same tree because it allows more people to work on it! The comment about JDBC is mostly about what the interface of the Java bindings should be. You almost certainly want to expose things as JDBC because that's what the rest of the ecosystem uses. The sqlite-jdbc project was just an example of how people do that in the SQLite ecosystem. |
Merged, by manually folding the commits into one. |
Purpose of this PR
Changes
bindings/java
directory.src
package for Java (Gradle) andrs_src
for Rust JNI code.Future Work
Issue
#615