Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup emitter some more #610

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Cleanup emitter some more #610

merged 1 commit into from
Jan 4, 2025
+2,268 −2,160

Conversation

jussisaurio
Copy link
Collaborator

@jussisaurio jussisaurio commented Jan 4, 2025 •
edited
Loading

No functional changes, just move almost everything out of emitter.rs into smaller modules with more distinct responsibilities. Also, from expr.rs, move translate_aggregation into aggregation.rs and translate_aggregation_groupby into group_by.rs

@jussisaurio
Copy link
Collaborator Author

emitter.rs should probably be renamed, but I can't think of a good name rn

@penberg penberg changed the title core/translate: emitter cleanup part 3 - break emitter.rs into smaller modules Cleanup emitter some more Jan 4, 2025
@penberg penberg merged commit 9f3e064 into main Jan 4, 2025
36 checks passed
@penberg penberg deleted the emitter-breakup branch January 4, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jussisaurio @penberg