Add OPFS support to WebAssembly bindings #534
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to tursodatabase#531 Add support for OPFS in WebAssembly bindings for browser storage. * **bindings/wasm/lib.rs** - Update `Database` constructor to handle OPFS option. - Modify `PlatformIO` to use OPFS for I/O in the browser. * **bindings/wasm/vfs.js** - Replace Node `fs` module with OPFS API. - Implement OPFS methods for `open`, `close`, `pread`, `pwrite`, `size`, and `sync`. * **bindings/wasm/docs/api.md** - Update documentation to mention OPFS support. - Add examples demonstrating usage with OPFS. * **bindings/wasm/examples/drizzle.js** - Update example to use OPFS for database storage. * **bindings/wasm/examples/example.js** - Update example to use OPFS for database storage. * **bindings/wasm/integration-tests/tests/test.js** - Update tests to use OPFS for database storage.
jussisaurio
reviewed
Dec 21, 2024
| let io: Arc<dyn limbo_core::IO> = if use_opfs { | ||
| Arc::new(PlatformIO { vfs: VFS::new() }) | ||
| } else { | ||
| Arc::new(PlatformIO { vfs: VFS::new() }) |
There was a problem hiding this comment.
what's going on here? both branches return the same thing
jussisaurio
reviewed
Dec 21, 2024
| } | ||
|
|
||
| open(path, flags) { | ||
| return fs.openSync(path, flags); | ||
| const fileHandle = { |
There was a problem hiding this comment.
I thought this PR was adding support for OPFS, not replacing Node.js support with it
jussisaurio
requested changes
Dec 21, 2024
|
@jussisaurio If any implementation leftover let me know on this I will work on it |
|
This does not actually add OPFS support although the PR says so. I am therefore closing it so thay anyone wanting to work on this wont be confused. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #531
Add support for OPFS in WebAssembly bindings for browser storage.
bindings/wasm/lib.rs
Databaseconstructor to handle OPFS option.PlatformIOto use OPFS for I/O in the browser.bindings/wasm/vfs.js
fsmodule with OPFS API.open,close,pread,pwrite,size, andsync.bindings/wasm/docs/api.md
bindings/wasm/examples/drizzle.js
bindings/wasm/examples/example.js
bindings/wasm/integration-tests/tests/test.js