Julianday function and additional tests/comments

tursodatabase · Jan 3, 2025 · 68b092c · 68b092c
1 parent 33532a0
commit 68b092c
Show file tree

Hide file tree

Showing 6 changed files with 289 additions and 311 deletions.
diff --git a/COMPAT.md b/COMPAT.md
@@ -221,11 +221,38 @@ Feature support of [sqlite expr syntax](https://www.sqlite.org/lang_expr.html).
 | date()      | Yes     | partially supports modifiers |
 | time()      | Yes     | partially supports modifiers |
 | datetime()  | Yes     | partially supports modifiers |
-| julianday() | No      |                              |
+| julianday() | Partial | does not support modifiers   |
 | unixepoch() | Partial | does not support modifiers   |
 | strftime()  | No      |                              |
 | timediff()  | No      |                              |
 
+### Date and Time Modifiers
+|  Modifier      | Status|  Comment                        |
+|----------------|-------|---------------------------------|
+| Days           | Yes 	 |                                 | 
+| Hours          | Yes	 |                                 |
+| Minutes        | Yes	 |                                 |
+| Seconds        | Yes	 |                                 |
+| Months         | Yes	 |                                 |
+| Years          | Yes	 |                                 |
+| TimeOffset     | Yes	 |                                 |
+| DateOffset	 | Yes   |                                 |
+| DateTimeOffset | Yes   |                                 |
+| Ceiling	     | No    |                                 |
+| Floor          | No    |                                 |
+| StartOfMonth	 | Yes	 |                                 |
+| StartOfYear	 | Yes	 |                                 |
+| StartOfDay	 | Yes	 |                                 |
+| Weekday(N)	 | Yes   |                                 |
+| Auto           | No    |                                 |
+| UnixEpoch      | No    |                                 |
+| JulianDay      | No    |                                 |
+| Localtime      |Partial| requires fixes to avoid double conversions.|
+| Utc            |Partial| requires fixes to avoid double conversions.|
+| Subsec         | Yes   |                                  |
+
+
+
 ### JSON functions
 
 | Function                           | Status  | Comment |

diff --git a/core/function.rs b/core/function.rs
@@ -108,6 +108,7 @@ pub enum ScalarFunc {
     Quote,
     SqliteVersion,
     UnixEpoch,
+    JulianDay,
     Hex,
     Unhex,
     ZeroBlob,
@@ -152,6 +153,7 @@ impl Display for ScalarFunc {
             Self::Unicode => "unicode".to_string(),
             Self::Quote => "quote".to_string(),
             Self::SqliteVersion => "sqlite_version".to_string(),
+            Self::JulianDay => "julianday".to_string(),
             Self::UnixEpoch => "unixepoch".to_string(),
             Self::Hex => "hex".to_string(),
             Self::Unhex => "unhex".to_string(),
@@ -360,6 +362,7 @@ impl Func {
             #[cfg(feature = "json")]
             "json_array" => Ok(Self::Json(JsonFunc::JsonArray)),
             "unixepoch" => Ok(Self::Scalar(ScalarFunc::UnixEpoch)),
+            "julianday" => Ok(Self::Scalar(ScalarFunc::JulianDay)),
             "hex" => Ok(Self::Scalar(ScalarFunc::Hex)),
             "unhex" => Ok(Self::Scalar(ScalarFunc::Unhex)),
             "zeroblob" => Ok(Self::Scalar(ScalarFunc::ZeroBlob)),

diff --git a/core/translate/expr.rs b/core/translate/expr.rs
@@ -1450,11 +1450,11 @@ pub fn translate_expr(
                             });
                             Ok(target_register)
                         }
-                        ScalarFunc::UnixEpoch => {
+                        ScalarFunc::UnixEpoch | ScalarFunc::JulianDay => {
                             let mut start_reg = 0;
                             match args {
                                 Some(args) if args.len() > 1 => {
-                                    crate::bail_parse_error!("epoch function with > 1 arguments. Modifiers are not yet supported.");
+                                    crate::bail_parse_error!("epoch or julianday function with > 1 arguments. Modifiers are not yet supported.");
                                 }
                                 Some(args) if args.len() == 1 => {
                                     let arg_reg = program.alloc_register();