make CI faster, more timeouts sooner #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioFranco
force-pushed
the
lucio/fix-ci
branch
from
ad116f2
to
fc93a88
Compare
LucioFranco
force-pushed
the
lucio/fix-ci
branch
from
2605ef0
to
8408f10
Compare
MarinPostma
reviewed
Nov 9, 2023
Comment on lines
-42
to
-50
|
|
||
| - name: reconfigure with Wasm in WasmEdge mode | ||
| run: make clean && ./configure --enable-wasm-runtime-wasmedge | ||
|
|
||
| - name: Run tests | ||
| run: make test | ||
|
|
||
| - name: Run tests with Wasm | ||
| run: make rusttestwasm |
There was a problem hiding this comment.
I talked with @psarna this morning, we don't need wasmedge right now and the first pass covers enough for all our C code. We were duplicating a lot of work.
Comment on lines
-1
to
-41
| name: Makefile CI | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ "main" ] | ||
| pull_request: | ||
| merge_group: | ||
| branches: [ "main" ] | ||
|
|
||
| jobs: | ||
| maketest: | ||
|
|
||
| runs-on: ubuntu-latest | ||
| defaults: | ||
| run: | ||
| working-directory: ./libsql-sqlite3 | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 | ||
|
|
||
| - name: get TCL | ||
| run: sudo apt-get install -y tcl8.6-dev | ||
|
|
||
| - name: Install Protoc | ||
| uses: arduino/setup-protoc@v2 | ||
|
|
||
| - name: Install Wasmpack | ||
| uses: jetli/[email protected] | ||
| with: | ||
| version: 'latest' | ||
|
|
||
| - name: configure | ||
| run: ./configure | ||
|
|
||
| - name: Run tests | ||
| run: make test | ||
|
|
||
| # Rust tests are run under maketestwasm | ||
|
|
||
| - name: Run API tests | ||
| run: make testlibsql |
There was a problem hiding this comment.
why is this going as well?
There was a problem hiding this comment.
Yup as I said above, a lot of our make tests did a lot of the same so if we just do it with + wasm then it covers basically everything. This was after a chat with @psarna.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libsql-sqlite3directory.cargo nextestto catch timeout tests so we don't get 3h+ CI jobs