make libsql client a valid target for cloudflare workers #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Horusiath
commented
Oct 24, 2023
LucioFranco
requested changes
Oct 24, 2023
| @@ -1,3 +1,4 @@ | |||
| /target | |||
| .vscode/ | |||
| .idea/ | |||
There was a problem hiding this comment.
I would add this to your global gitignore https://gist.github.com/subfuzion/db7f57fff2fb6998a16c so you don't need to add it to every project.
There was a problem hiding this comment.
Same could be said about .vscode/ path ;)
libsql/src/database.rs
Outdated
| @@ -163,15 +164,27 @@ cfg_replication! { | |||
|
|
|||
| cfg_hrana! { | |||
| impl Database { | |||
| #[cfg(not(feature = "hrana-cf"))] | |||
There was a problem hiding this comment.
So this breaks how features should work in rust. They must be additive aka enabling A and B shouldn't disable features from B, since another crate in the workspace can enable the feature B and break code that depended on A.
libsql/src/local/impls.rs
Outdated
Comment on lines
18
to
19
| #[cfg_attr(feature = "hrana-cf", async_trait::async_trait(?Send))] | ||
| #[cfg_attr(not(feature = "hrana-cf"), async_trait::async_trait)] |
There was a problem hiding this comment.
I don't think this is the right approach we should take since we need these features to be additive.
Horusiath
force-pushed
the
libsql-cloudflare-target
branch
from
f2f71bb
to
8e2f0c1
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new feature:
cloudflare-worker, which enables Hrana protocol to be served over Cloudflare workers.