rusqlite #457
Closed
rusqlite #457
+831,207
−3,086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impl Debug for Row
Intoduce one_column for tests
Fix #882 for valid JSON values
Flushing the buffer on each new entry makes iotrace much more useful for debugging interactive sessions.
We don't use Fossil nor plan to, so drop the config.
The distinction will make it abundantly clear that the user is running libSQL.
If it fails, it should not break the build.
Currently, the runtime of choice is wasmtime and its libwasmtime.so library, available at https://github.com/bytecodealliance/wasmtime/releases
From now on, configuring with ./configure --enable-wasm-runtime turns on WebAssembly integration.
The function can be used to run abitrary WebAssembly
functions. It takes the WebAssembly module body
and the function name in user data, and forwards
all the arguments to this function as is.
The final ABI for these functions still remains to be specified,
but for now the following assumptions hold true:
- integers are passed as is
- doubles are passed as is
- strings are passed as a pointer to the following structure:
[1 byte with value SQLITE_TEXT (3)][data]
- blobs are going to be passed as a pointer to:
[1 byte with value SQLITE_BLOB (4)][4 bytes of size][blob]
... but are not supported yet
- nulls are passed as a pointer to:
[1 byte with value SQLITE_NULL (5)]
... but are not supported yet
In addition to looking up all of the built-in and user-defined functions, they can now also be stored in a special libsql_wasm_func_table table. This table's schema is name text PRIMARY KEY, body text , where `body` is expected to be valid WebAssembly code represented in .wat - WebAssembly Text Format. The WebAssembly module compiled from this source code should export a function with name `name`, which can then be called as if it was a regular user-defined function. The implementation is deeply experimental, as there is no cache of compiled programs whatsoever, so running these functions is heavy and involves recompiling the source each time.
The routines will later be called when parsing CREATE FUNCTION and DROP FUNCTION statements, which are more or less syntactic sugar over inserting an entry in the libsql_wasm_func_table table (or deleting from it, accordingly).
The helper routine which compiles WebAssembly and registers the wasm function dynamically is now split into two parts - one will be used when parsing to validate the output WebAssembly.
The routine creates the libsql_wasm_func_table table, responsible for storing WebAssembly source code for dynamically added Wasm functions.
It will be used to drop functions via the DROP FUNCTION statement.
The table will be created on startup in order to allow registering Wasm functions dynamically.
The new experimental syntax loosely follows SQL's CREATE FUNCTION. It still misses OR REPLACE keywords which would allow overriding an already existing function.
The suite is wrapped in a feature flag, because user-defined functions need to be compiled opt-in into libSQL.
The new command runs Rust test with udf feature enabled, which assumes that libSQL was compiled with --enable-wasm-runtime.
Previous dynamic lookup of Wasm function was lazy and only performed on its first use - this is redundant, and the logic is much clearer when the functions are initialized on startup + when they're registered dynamically.
The newly covered cases also check operations on strings, blobs and null.
This document will serve as an entrypoint for various extensions added to libSQL and not necessarily compatible with SQLite. Eventually it might grow to become a separate directory.
Before the fix, single quotes were not properly loaded from the database.
If .init_wasm_func_table is the initial call to the shell, call open_db() first to initialize the connection.
Use track_caller for panicking methods
Force linking against system sqlite libs
Fix clippy warnings
fix compilation for target wasm32-wasi
Add SQLITE_MAX_COLUMN compile-time option
Following the mechanism already present for picking sqlite3 or sqlcipher, libsql backend is added, guarded by a new opt-in feature - bundled-libsql.
The call is idempotent and for best user experience, it's just injected into connection initialization.
Modeled after open_with_flags_and_vfs, now users are also able to open a connection with custom WAl methods via open_with_flags_and_wal. Technically these parameters should be moved to a map or a config struct to avoid an exponential explosion, but for now, open_with_flags_and_vfs_and_wal is simply not available.
The dependency is only used with `libsql-wasm` backend.
Specific to libSQL 0.2.1.
Re export transaction state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.