Use read_exact instead of read_exact_at
#325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR currently breaks, but #324 fixes the import error |
avinassh
changed the title
read_at instead of read_exact_atread_exact instead of read_exact_at
|
Hey @avinassh! The change looks good to me, but I also wonder why we're reading twice. Let's try to get @MarinPostma or @psarna to have a look at this before merging. |
|
Looks good. Idk why we were reading twice, likely a mistake |
|
Do we want to bother with making sqld compile on windows? Just asking |
|
@MarinPostma Sure, I think it's good to keep stuff running on Windows when possible. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
325: remove posgres wire over ws, and refactor r=MarinPostma a=MarinPostma remove posgres wire porotocol over websocket and refactor to simlify architecture Co-authored-by: ad hoc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to use libsql API library and aiming to cross compile my app across OS. Currently it uses a *nix OS specific import and can't be used on Windows. This patch tries to fix that.
read_exact_atbut at offset zero, so it is same asread_exact