libsql/core: Implement Database::sync() in V2 #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioFranco
reviewed
Aug 25, 2023
| @@ -20,7 +20,7 @@ pub use transaction::Transaction; | |||
| enum DbType { | |||
| Memory, | |||
| File { path: String }, | |||
| Sync { path: String, url: String, token: String }, | |||
| Sync { db: crate::Database }, | |||
There was a problem hiding this comment.
Oh smart... we should do that same for path and memory?
MarinPostma
added a commit
that referenced
this pull request
Oct 17, 2023
317: Streaming replication r=MarinPostma a=MarinPostma This pull request implements streaming replication to replace poll-based replication. here is an overview of the protocol: 1) replica sends hello to primary 2) primary responds with current replication meta 3) replica sends `Frames` rpc with its current replication progress 4) primary starts streaming frames to the replica 5) replica injects frames on the fly into the database, transaction by transaction 6) if a snapshot is required, the replica downloads the snapshot, applies the snapshot, and reissues a call to `Frames` with its updated replication progress 7) if the primary is out of pages to send, it waits until new pages become available. The replication code has been restructured significantly, and it should be much easier to follow now. Co-authored-by: ad hoc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.