Create CONTRIBUTING.md #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abdur-rahmaanJ
suggested changes
Aug 20, 2023
There was a problem hiding this comment.
Thanks for the PR, though is am not a maintainer, i'd suggest including instructions to clone the project from scratch, run it, play around with it, create branches to submit changes, running and writing tests, pushing ...
I think then the contribution might be more meaningful. Maybe try a basic contribution guide and iterate on maintainers advises.
|
Okay @Abdur-rahmaanJ thanks for suggestion . I will update accordingly. |
MarinPostma
pushed a commit
that referenced
this pull request
Oct 17, 2023
300: Hrana batches r=honzasp a=honzasp The whole "edge" is (only) about reducing latency, so sqld clients should strive to minimize the number of network roundtrips. This means that users should prefer batched transactions to interactive transaction; these should take just a single roundtrip. Unfortunately, up until now it was impossible to safely implement batched transactions in Hrana with just a single roundtrip. To execute a batch of statements _S1, ..., Sn_, we need to do the following: - Execute a `BEGIN` statement - If the `BEGIN` statement was successful, execute _S1_ - If `BEGIN` and _S1_ were successful, execute _S2_ - ... - If `BEGIN` and _S1, ..., Sn-1_ were successful, execute _Sn_ - If `BEGIN` and _S1, ..., Sn_ were successful, execute `COMMIT`, otherwise execute a `ROLLBACK` In other words, we need to execute statements conditionally, based on results of previous statements. The only way to do this in Hrana is to wait for the responses, so we need _n+2_ roundtrips instead of just one! --- This PR changes that by introducing the concept of "batch" to the Hrana protocol. A batch is a sequence of steps, and each step is an SQL statement with optional condition. The condition can refer to success or failure of previous steps. This mechanism will allow clients to implement batched transactions using a single roundtrip. This PR replaces #294 and #295 after discussion with `@MarinPostma.` Co-authored-by: Jan Špaček <[email protected]>
haaawk
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding issue -:#288