Fix compilation errors on platforms with unsigned chars #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`*const i8`/`*mut i8` was passed in a bunch of places where `*const c_char`/`*mut c_char` was expected which didn't compile on Linux on aarch64.
psarna
approved these changes
Aug 14, 2023
MarinPostma
added a commit
that referenced
this pull request
Oct 17, 2023
281: load dumps from CLI r=MarinPostma a=MarinPostma This PR enables loading a dump file from the CLI. Co-authored-by: ad hoc <[email protected]>
MarinPostma
added a commit
that referenced
this pull request
Oct 17, 2023
282: remove dump http route r=MarinPostma a=MarinPostma Removes the `/dump` http route, replaced with #281 Co-authored-by: ad hoc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*const i8/*mut i8was passed in a bunch of places where*const c_char/*mut c_charwas expected which didn't compile on Linux on aarch64.