Initial offline write support #1801
Merged
+577
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penberg
force-pushed
the
push-sync
branch
5 times, most recently
from
2a1fa88
to
18f4442
Compare
penberg
force-pushed
the
push-sync
branch
3 times, most recently
from
436679d
to
d4f6b22
Compare
LucioFranco
approved these changes
Nov 13, 2024
| async fn push_with_retry(&self, uri: String, auth_token: &Option<String>, frame: Vec<u8>, max_retries: usize) -> Result<()> { | ||
| let mut nr_retries = 0; | ||
| loop { | ||
| let client = reqwest::Client::new(); |
There was a problem hiding this comment.
Whats the reason for using reqwest instead of just hyper directly? We also probably want to cache this client so we can re-use its dns resolution/tls handshake.
There was a problem hiding this comment.
No other reason than it was easier to get TLS going with reqwest. I don't mind someone rewriting it to use Hyper after this lands in main.
Comment on lines
+3
to
+6
| pub sync_url: String, | ||
| pub auth_token: Option<String>, | ||
| pub max_retries: usize, | ||
| pub durable_frame_num: u32, |
There was a problem hiding this comment.
We should provide getters for these rather than expose them. I can do this in a follow up.
This patch add initial support for offline writes. To open a local database that can sync to remote server, use the Builder::new_synced_database() API. The protocol on server side is simple: **POST** `/sync/<generation>/<start_frame>/<end_frame>` where request body is the WAL frames.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new type of database, synced database, which
allows local writes that can sync to a remote server.
The protocol on server side is simple:
POST
/sync/<generation>/<start_frame>/<end_frame>where request body is the WAL frames.