Fix phpunit with Moodle 4.3 and PHP 8.2. #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaboesch
added a commit
to lucaboesch/moodle-plagiarism_turnitin
that referenced
this pull request
Aug 5, 2024
lucaboesch
added a commit
to lucaboesch/moodle-plagiarism_turnitin
that referenced
this pull request
Aug 5, 2024
lucaboesch
added a commit
to lucaboesch/moodle-plagiarism_turnitin
that referenced
this pull request
Aug 5, 2024
lucaboesch
added a commit
to lucaboesch/moodle-plagiarism_turnitin
that referenced
this pull request
Aug 5, 2024
lucaboesch
added a commit
to lucaboesch/moodle-plagiarism_turnitin
that referenced
this pull request
Aug 13, 2024
lucaboesch
added a commit
to lucaboesch/moodle-plagiarism_turnitin
that referenced
this pull request
Aug 13, 2024
jack-tii
approved these changes
Aug 14, 2024
|
Thanks! And, in case you have not seen this bit of Moodle development news: Right now there is a know issue with https://moodlehq.github.io/moodle-plugin-ci/. See moodlehq/moodle-plugin-ci#309 and nvm-sh/nvm#3405 for details. Hopefully that gets sorted soon. |
lucaboesch
added a commit
to lucaboesch/moodle-plagiarism_turnitin
that referenced
this pull request
Aug 15, 2024
lucaboesch
added a commit
to lucaboesch/moodle-plagiarism_turnitin
that referenced
this pull request
Aug 21, 2024
lucaboesch
added a commit
to lucaboesch/moodle-plagiarism_turnitin
that referenced
this pull request
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing PHPunit failures after installing this plugin into Moodle 4.3 (with PHP 8.2).
This is one way to fix it. May not be the most elegant, but I hope it is OK.
Among other things, this fixes issue #712.
I tested on Moodle 4.1 with PHP 7.4 to verify that I had not broken anything.
I hope this is helpful @carl-hostrander.