Refactor/companies dynamic #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d from all but company name
nies spec
stefanjbloom
requested changes
Jan 7, 2025
| application_url: string; | ||
| contact_information: string; | ||
| company_id: number; | ||
| company_name?: string; | ||
| } |
There was a problem hiding this comment.
The usage of an Interfaces file(and an api fetch file since it's the same idea) for all component usage is mega SRP. Perhaps an issue can be made to migrate all interfaces to this file?
| {companyName} | ||
| </td> | ||
| <td className="p-4 border-b truncate max-w-[8vw]">{data.attributes.notes}</td> | ||
| </tr> | ||
| ) |
There was a problem hiding this comment.
This addition/subtraction looks identical, unless I am mistaken. Nonetheless it makes sense.
stefanjbloom
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Overview
This PR introduces improved dynamic data handling for the Companies and Contacts modules. Updates include API-driven rendering, refactored Cypress tests for dynamic data, and UI enhancements for a better user experience.
Key Changes
Dynamic Contacts Integration
/companies/:id/contactsAPI endpoint.CompanyShowcomponent to display fetched contact data.Dynamic Job Applications Integration
Enhanced Cypress Tests
CompaniesandCompany Showpages are updated to validate API-driven dynamic data.Form Enhancements
NewCompanyform fields for better usability.Cypress Test Refactoring
userIdfor intercepts.GET /users/:id/job_applicationsMotivation and Context
This fulfills the FE portion of #65
Added Test?
Checklist: