Skip to content

Commit

Permalink
Merge pull request #374 from turingschool/capstone_edit
Browse files Browse the repository at this point in the history
Move PR feedback criteria to git workflow portion of rubric
  • Loading branch information
epintozzi authored Dec 20, 2024
2 parents 92dc414 + 65aca75 commit 864bfa7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion module4/projects/capstone/evaluation.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ Students are expected to score in the **Meets Expectations** category. If any on
* Moves tasks along on the project board in real time (or close to it)
* Communicates effectively with team members and project manager through appropriate channels
* Collaborates well on pair programming tasks, showing both the ability to lead and follow
* Provides constructive and actionable feedback on at least 3 pull requests
* Seeks clarification when requirements or tasks are unclear
* Demonstrates active listening skills during team discussions and meetings
* Shows willingness to help team members when they encounter difficulties
Expand Down Expand Up @@ -162,6 +161,7 @@ Students are expected to score in the **Meets Expectations** category. If any on
* App has passing CI and is deployed successfully after every PR is merged
- **Meets Expectations:**
* Uses Pull Request templates and at least three PRs include specific questions/asks of the code reviewer
* Provides constructive and actionable feedback on at least 3 pull requests
* Writes clear and descriptive commit messages following a consistent convention
* Creates focused, small pull requests that are easy to review, but one may be larger than expected
* Regularly pushes code and keeps the remote repository up-to-date
Expand Down

0 comments on commit 864bfa7

Please sign in to comment.