-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tommy Takahashi and Sam Tran #93
Open
Sykogst
wants to merge
86
commits into
turingschool-examples:main
Choose a base branch
from
ttakahashi1591:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gems Set-Up
… show page redirecting to the User Discover Index page
…n which lists viewing parties
User Dashboard Page
…o UsersController
Dashboard Viewing Parties
…ent for readability, remove handrolled route
…as private methods
Thanks for taking care of these refactors and updates!
…on_happy_path Register With Authentication Happy Path
…cation_sad_path Registration (w/ Authentication) Sad Path
Logging In Happy Path
Logging In Sad Path
…uests to the database
…er_method Add Sessions And Memoization Of Current User
Log Out A User
Complete Task 3: User Story 1
Task 4: User Story 2 & Task 5: User Story 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We think the project went well and it was fun working with each other. We are proud of learning how to do API consumption and refactoring it using the service/facade/poro organization structure.
We would like feedback specifically on a couple of things.