Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Joop and Reed Turn-in #82

Open
wants to merge 100 commits into
base: main
Choose a base branch
from
Open

Joop and Reed Turn-in #82

wants to merge 100 commits into from

Conversation

JoopStark
Copy link

No description provided.

JoopStark and others added 30 commits October 9, 2023 15:26
@JoopStark
setup: complete
5ffa45a
@JoopStark
add: routes
0b671b3
@reedhillmar
Merge pull request #8 from JoopStark/joop-landing
abf0dc4 
Joop landing
@reedhillmar
setup: adds gems
d6aa92a
@reedhillmar
setup: schema setup
6bef21a
@reedhillmar
setup: more validations
667acf2
@reedhillmar
setup: viewing party validations
7559de2
@reedhillmar
test: adds model tests
be95b30
@JoopStark
Merge pull request #9 from JoopStark/reed_setup
028904b 
Reed setup
@JoopStark
user views
9444e4e
@JoopStark
Merge branch 'main' of github.com:JoopStark/viewing_party_lite_7 into…
1eeef9f 
… joop-landing
@reedhillmar
Merge pull request #10 from JoopStark/joop-landing
519a1aa 
user views
@JoopStark
feat tests: welcome index page; header, new user button, current user…
aa9d11e 
… email links
@JoopStark
Merge branch 'main' into joop-landing
f229692
@JoopStark
feat test: user show page has header, discover button, and table with…
b3fd397 
… viewing party attributes
@JoopStark
Merge branch 'main' of github.com:JoopStark/viewing_party_lite_7 into…
5e4387b 
… joop-landing
@JoopStark
Merge branch 'joop-landing' of github.com:JoopStark/viewing_party_lit…
d5166bb 
…e_7 into joop-landing
@reedhillmar
Merge pull request #11 from JoopStark/joop-landing
712a008 
Joop landing
@JoopStark
feat test bug fixes: changed buttons from post to get
314bbc2
@JoopStark
schema: add image_path column to viewing_parties
7f42d38
@reedhillmar
Merge pull request #22 from JoopStark/joop-landing
7cc1e26 
Joop landing
@reedhillmar
feat: adds discover page and the start of search form
20b2c28
@JoopStark
Merge pull request #23 from JoopStark/reed_discover
b1f79c0 
feat: adds discover page and the start of search form
@JoopStark
feat: movies index controller, changed schema
c4472fc
@reedhillmar
Merge pull request #24 from JoopStark/joop-spike
3666c3f 
feat: movies index controller, changed schema
@JoopStark
fix schema and test helper
911998b
@reedhillmar
Merge pull request #25 from JoopStark/joop-movies_index
9bcc25e 
fix schema and test helper
@JoopStark
gems and vcr setup
9077e8a
@reedhillmar
test: adds test for basic page setup
0f6dc5d
@JoopStark
Merge pull request #27 from JoopStark/movie_details
8acfae3 
test: adds test for basic page setup
JoopStark and others added 30 commits October 13, 2023 11:10
@JoopStark
fix: sad path created nil rounding problem with movie.vote average
2cd453b
@JoopStark
refactor: movie.vote_average
5011603
@JoopStark
Merge pull request #37 from JoopStark/reed_poro
aa9ae81 
Reed poro
@reedhillmar
Merge branch 'main' into joop-movie_poro
292c1ec
@reedhillmar
Merge pull request #36 from JoopStark/joop-movie_poro
d06c12e 
Joop movie poro
@JoopStark
service test: Movie Service
3e19695
@reedhillmar
test: adds testing for POROs and fixes welcome index test
a1aa0d6
@JoopStark
Merge pull request #38 from JoopStark/reed_tests
a094903 
test: adds testing for POROs and fixes welcome index test
@JoopStark
create facade test
4fd7179
@JoopStark
Merge branch 'main' of github.com:JoopStark/viewing_party_lite_7 into…
b34778c 
… joop-movie_poro
@JoopStark
service test: MoviesService
3055a4a
@JoopStark
refactor: rubocoped facade spec
48c6805
@reedhillmar
fix: rubocop fixes
47fa99e
@JoopStark
refactor: rubocoped specs: models, facade, services
d097713
@reedhillmar
fix: rubocop pulled me over for double quotes and issued me a citation
6499141
@JoopStark
Merge pull request #39 from JoopStark/reed_rubocop
02b1992 
Reed rubocop
@JoopStark
merge conflict fix, took incoming
7cce921
@JoopStark
cleeeeean
fed8234
@JoopStark
Merge pull request #40 from JoopStark/joop-movie_poro
54a46ee 
Joop movie poro
@JoopStark
refactored user show page
1ec1b8d
@reedhillmar
refactor/test/fix: small tweaks to cover bases for all user stories, …
faa1589 
…everything works
@JoopStark
Merge pull request #41 from JoopStark/reed_rubocop
27e3813 
refactor/test/fix: small tweaks to cover bases for all user stories, …
@JoopStark
Merge branch 'main' of github.com:JoopStark/viewing_party_lite_7 into…
a36d01f 
… joop-movie_poro
@reedhillmar
Merge pull request #42 from JoopStark/joop-movie_poro
e97385e 
Joop movie poro
@JoopStark
refactory: pagentry
28efdb0
@reedhillmar
Merge pull request #43 from JoopStark/joop-demo
2df584f 
refactory: pagentry
@JoopStark
test feat: authentication
de082f1
@JoopStark
Merge pull request #44 from JoopStark/joop-authentication
ac2eec7 
test feat: authentication
@JoopStark
removed pry
e845db8
@JoopStark
authorization
22da37a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoopStark @reedhillmar