Martin Chavez #9
Conversation
| @@ -0,0 +1,8 @@ | |||
| class DishIngredientsController < ApplicationController | |||
There was a problem hiding this comment.
Nice use of the joins controller!
| has_many :ingredients, through: :dish_ingredients | ||
|
|
||
| def unique_ingredients | ||
| ingredients.distinct.pluck(:name) |
There was a problem hiding this comment.
Nice work! Adding the additional association makes this logic much easier. Great job remembering the distinct!
| has_many :ingredients, through: :dish_ingredients | ||
|
|
||
| def total_calories | ||
| ingredients.sum(:calories) |
There was a problem hiding this comment.
nice encapsulation of this logic in a model method!
|
|
||
| <p>Add Ingredient</p> | ||
|
|
||
| <%= form_with(url: dish_ingredients_path(@dish), method: :post) do |form| %> |
There was a problem hiding this comment.
Beautiful form implementation! Great RESTful path and method
| end | ||
|
|
||
| resources :chefs, only: [:show,] do | ||
| resources :ingredients, only: [:index] |
There was a problem hiding this comment.
Great RESTful routing! Another option here could be to use a nested controller since the ingredients are nested under chefs (you could add controller: "chefs/ingredients" at the end of line 12 to force the controller)
| expect(page).to have_content('Cheese') | ||
| # And I see a list of ingredients for that dish | ||
|
|
||
| expect(page).to have_content('Calorie Count: 500') |
There was a problem hiding this comment.
Awesome job tying this calculation to the text it should appear next to!
| RSpec.describe Ingredient, type: :model do | ||
| it { should have_many :dish_ingredients } | ||
| it { should have_many(:dishes).through(:dish_ingredients) } | ||
| end |
There was a problem hiding this comment.
Excellent unit testing in your model specs!
I felt confident about going into the IC! The practice does really help! I made sure to make my test as robust as possible!